Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sideeffects; part 5 #1509

Merged
merged 6 commits into from
Dec 25, 2024
Merged

feat: add sideeffects; part 5 #1509

merged 6 commits into from
Dec 25, 2024

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Dec 19, 2024 •
edited
Loading

Опишите проблему

Добавлено "sideEffects": false, чтобы бандлер лучше делал тришейк

Дополнительная информация

уже замерженые
part 1 #1480
part 2 #1486
part 3 #1491
part 4 #1497

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 664ee97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 88 packages
Name Type
@alfalab/core-components-drawer Patch
@alfalab/core-components-notification Patch
@alfalab/core-components-notification-manager Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-pagination Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-pattern-lock Patch
@alfalab/core-components-pattern-lock-v1 Patch
@alfalab/core-components-popover Patch
@alfalab/core-components-popup-sheet Patch
@alfalab/core-components-portal Patch
@alfalab/core-components-product-cover Patch
@alfalab/core-components-pure-cell Patch
@alfalab/core-components-radio Patch
@alfalab/core-components-radio-group Patch
@alfalab/core-components-segmented-control Patch
@alfalab/core-components-shared Patch
@alfalab/core-components-skeleton Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-status-badge Patch
@alfalab/core-components-stepped-progress-bar Patch
@alfalab/core-components-switch Patch
@alfalab/core-components-system-message Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-side-panel Patch
@alfalab/core-components-table Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-toast Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-base-modal Patch
@alfalab/core-components-sortable-list Patch
@alfalab/core-components-action-button Patch
@alfalab/core-components-amount-input Patch
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components-button Patch
@alfalab/core-components-calendar Patch
@alfalab/core-components-checkbox-group Patch
@alfalab/core-components-checkbox Patch
@alfalab/core-components-code-input Patch
@alfalab/core-components-confirmation Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-filter-tag Patch
@alfalab/core-components-form-control Patch
@alfalab/core-components-input Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-markdown Patch
@alfalab/core-components-modal Patch
@alfalab/core-components-navigation-bar-private Patch
@alfalab/core-components-navigation-bar Patch
@alfalab/core-components-pass-code-v1 Patch
@alfalab/core-components-pass-code Patch
@alfalab/core-components-spinner Patch
@alfalab/core-components-tab-bar Patch
@alfalab/core-components-tabs Patch
@alfalab/core-components-tag Patch
@alfalab/core-components-textarea Patch
@alfalab/core-components-toast-plate Patch
@alfalab/core-components-calendar-with-skeleton Patch
@alfalab/core-components-typography Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-attach Patch
@alfalab/core-components-confirmation-v1 Patch
@alfalab/core-components-custom-button Patch
@alfalab/core-components-icon-button Patch
@alfalab/core-components-plate Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-file-upload-item-v1 Patch
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-accordion Patch
@alfalab/core-components-chart Patch
@alfalab/core-components-circular-progress-bar Patch
@alfalab/core-components-comment Patch
@alfalab/core-components-list-header Patch
@alfalab/core-components-list Patch
@alfalab/core-components-alert Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@core-ds-bot
Copy link
Collaborator

core-ds-bot commented Dec 19, 2024 •
edited
Loading

Bundle size report

Entry point Size (minified)
system-message/shared.js 0.3 (-2.80 KB💚)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@denisx denisx marked this pull request as ready for review December 20, 2024 06:04
@hextion hextion merged commit 4b9f169 into master Dec 25, 2024
7 checks passed
@hextion hextion deleted the feat/ds-7758_33 branch December 25, 2024 07:40
NikitaRodyukov pushed a commit that referenced this pull request Dec 25, 2024
@denisx @NikitaRodyukov
feat: add sideeffects; part 5 (#1509)
1887393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulcanellee fulcanellee fulcanellee approved these changes

@hextion hextion hextion approved these changes

@SiebenSieben SiebenSieben SiebenSieben approved these changes

@reme3d2y reme3d2y Awaiting requested review from reme3d2y reme3d2y is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@denisx @core-ds-bot @SiebenSieben @hextion @fulcanellee